Skip to content

active 2024-01-242024-02-19 (UTC)

Complete coverage26,691 / 26,691 hourly files (100%) · 2 absent upstream2023-08-152026-08-31 (UTC)
Events
49
Pushes
7
Pull requests
0
Issues
34
Stars
0
Forks
0

Activity over time

Daily event counts in the loaded window

Line chart, 27 days from 2024-01-24 to 2024-02-19. Pushes: 7 total, peak 4 in a day. Pull requests: 0 total, peak 0 in a day. Issues: 34 total, peak 13 in a day. Comments: 6 total, peak 3 in a day. Stars: 0 total, peak 0 in a day.

  • Pushes
  • Pull requests
  • Issues
  • Comments
  • Stars

Top contributors

Pushes, PRs, issues, reviews and comments — stars and forks excluded, so this is contribution rather than popularity

ContributorContributionsPushesPRsComments
MeFay30706
giselacostamindera17000

Recent activity

Latest issues, pull requests and releases

  • Issue#20giselacostamindera2024-02-12 14:02
    No need to use @SpringBootTest on unitary tests https://reflectoring.io/spring-boot-test/ you just need MockitoAnnotations.openMocks(this); on tests setup
  • Issue comment#13MeFay2024-02-09 15:32
    Please focus on the requirements, you still have the email requirements missing
  • Issue#13MeFay2024-02-09 15:32
    Please focus on the requirements, you still have the email requirements missing
  • Issue#18MeFay2024-02-09 15:30
    This is not doing anything here, you need to mock userRepository.findById (that is what you use in update)
  • Issue#14MeFay2024-02-09 15:24
    I believe you do not need this UserController, you should use the InjectMocks on the unitary tests on class UserServiceTest
  • Issue#11MeFay2024-02-09 15:23
    Check if null or empty, because if empty you cannot update it
  • Issue#10MeFay2024-02-09 15:23
    Check if null or empty, because if empty you cannot update it
  • Issue comment#9MeFay2024-02-09 15:13
    In patch username can be null, because if null you keep the one that is on the DB
  • Issue#9MeFay2024-02-09 15:13
    In patch username can be null, because if null you keep the one that is on the DB
  • Issue#8MeFay2024-02-09 15:09
    Please throw UserNotFoundException, so that we understand what is breaking
  • Issue comment#7MeFay2024-02-09 15:08
    validate first if userDto is null, and if null you can throw a UserIsNullException
  • Issue#7MeFay2024-02-09 15:08
    validate first if userDto is null, and if null you can throw a UserIsNullException
  • Issue#6MeFay2024-02-09 15:07
    Try to make the names of the exceptions more clear, like UsernameIsEmptyException, but it is great you are using the custom exceptions.
  • Issue#3MeFay2024-02-09 15:05
    Do not forget to do the validations needed to accomplish the requirements for creation and user update (email cannot be null, email cannot be updated, etc)
  • Issue#2MeFay2024-02-09 15:03
    If user is null you could try a custom exception (eg.UserNotFoundException extends RuntimeException)
  • Issue#1MeFay2024-02-09 15:03
    If user is null you could try a custom exception (eg.UserNotFoundException extends RuntimeException)
  • Issue#4MeFay2024-02-09 15:01
    Try to have only one UserDto, if you need more info you can have a UserWithPasswordDto that extends UserDto
  • Issue comment#5MeFay2024-02-07 22:07
    Great work, you separate UserDto and UserEntity!
  • Issue#5MeFay2024-02-07 22:07
    Great work, you separate UserDto and UserEntity!
  • Issue comment#12MeFay2024-02-07 21:05
    Please throw UserNotFoundException
  • Issue#12MeFay2024-02-07 21:05
    Please throw UserNotFoundException
  • Issue#16MeFay2024-02-07 21:00
    You are testing the updateUser test, please refactor the test name -> .put("/user/1")
  • Issue comment#19MeFay2024-02-07 17:47
    This method is the updateUserFailure -> .put("/user/1")
  • Issue#19MeFay2024-02-07 17:47
    This method is the updateUserFailure -> .put("/user/1")
  • Issue#19giselacostamindera2024-02-06 22:03
    This method is the updateUserFailure -> .put("/user/1")

Totals cover only the window loaded into ClickHouse and count events, not GitHub's lifetime totals — 0 stars here means stars gained during the window, not the repo's star count.