active 2024-01-23 → 2024-02-15 (UTC)
Complete coverage26,684 / 26,684 hourly files (100%) · 2 absent upstream2023-08-15 → 2026-08-30 (UTC)
Events
98
Pushes
12
Pull requests
21
Issues
43
Stars
0
Forks
0
Activity over time
Daily event counts in the loaded window
Line chart, 24 days from 2024-01-23 to 2024-02-15. Pushes: 12 total, peak 2 in a day. Pull requests: 21 total, peak 4 in a day. Issues: 43 total, peak 15 in a day. Comments: 3 total, peak 2 in a day. Stars: 0 total, peak 0 in a day.
- Pushes
- Pull requests
- Issues
- Comments
- Stars
Top contributors
Pushes, PRs, issues, reviews and comments — stars and forks excluded, so this is contribution rather than popularity
| Contributor | Contributions | Pushes | PRs | Comments |
|---|---|---|---|---|
| rickymoz | 53 | 12 | 21 | 0 |
| giselacostamindera | 26 | 0 | 0 | 3 |
Recent activity
Latest issues, pull requests and releases
- Pull request#35rickymoz2024-02-15 08:52
- Pull request#35rickymoz2024-02-15 08:51
- Issue#5rickymoz2024-02-15 08:50Check if user is null
- Issue#6rickymoz2024-02-15 08:28Exception could have a better name like UserPropertiesNullOrEmptyException
- Issue#7rickymoz2024-02-15 08:26check if user.getUsername() is null, if yes you will have a nullpointer exception -> add tests for this scenarios
- Issue#8rickymoz2024-02-15 08:16Check if user exists like you do for update and add test for this scenario
- Pull request#34rickymoz2024-02-14 21:17
- Issue#9rickymoz2024-02-14 19:56Check if user exists like you do for update and add test for this scenario
- Issue#11rickymoz2024-02-14 19:41Great, you paid attention to the requirements :)
- Issue#15rickymoz2024-02-14 19:14You could use Parametrized tests and have one test instead of 3 tests
- Issue#16rickymoz2024-02-14 19:13Not sure how this works without having userRepository.findAll() mocked.... when(userRepository).findAll().thanReturn(users);
- Issue#17rickymoz2024-02-14 19:11Not sure how this works since you are mocking id 1L and you are trying to update user with id 2L
- Issue#18rickymoz2024-02-14 19:08I like the way you do the mocks here, I prefer when all variables are defined on the test
- Issue#20rickymoz2024-02-14 19:04Please move this class to package services
- Issue#21rickymoz2024-02-14 19:01You could verify if User is what you expect it to be
- Issue#23rickymoz2024-02-14 18:49Please check that userRepository is called verify(userRepository, times(1)).save(user);
- Issue#24rickymoz2024-02-14 18:39Check that retrievedUser is what you expect, it could be an optional that returns empty and your test was passing
- Issue#25rickymoz2024-02-14 18:34Please check findById is called verify(userRepository, times(1)).findById(user.getId())
- Issue#26rickymoz2024-02-14 18:06Although if you do not mock it is still working, make the mock explicit: when(userRepository.findById(user.getId())).thenReturn(null);
- Issue#27rickymoz2024-02-14 17:56Please check the DB call findById and save are being called verify(userRepository, times(1)).findById(user.getId())); verify(userRepository, times(1)).save(user))
- Issue#28rickymoz2024-02-14 17:47Please mock explicitly that findById should return null when(userRepository.findById(user.getId())).thenReturn(null)
- Issue#29rickymoz2024-02-14 17:40Please check that findById is called but save is not called Also check that userRepository.findById is called but userRepository.save is not called verify(userRepository, times(1)).findById(user.getId())); verify(userRepository, times(0)).save(user));
- Pull request#33rickymoz2024-02-13 19:03
- Pull request#33rickymoz2024-02-13 19:03
- Pull request#32rickymoz2024-02-13 18:34
Totals cover only the window loaded into ClickHouse and count events, not GitHub's lifetime totals — 0 stars here means stars gained during the window, not the repo's star count.